Namya Sehgal

Results 7 comments of Namya Sehgal

> Does the Oracle connector doc need a Type Mapping section similar to https://prestodb.io/docs/current/connector/iceberg.html#type-mapping ? > > If yes, either you can add it in this PR, or I can...

> Are there any existing product tests that run on jdbc sources? @namya28 There are integration smoke tests for the Oracle connector, which validate that Presto can connect to Oracle...

> > > Does the Oracle connector doc need a Type Mapping section similar to https://prestodb.io/docs/current/connector/iceberg.html#type-mapping ? > > > If yes, either you can add it in this PR,...

> LGTM! (docs) > > Thank you for adding this to the doc! @steveburnett , Corrected a tiny spelling check and pushed again. Could you please help review again!

> Can you add a test? Hi @rschlussel , The existing tests for Oracle are currently disabled, and I was unable to locate any corresponding product tests. As a result,...

Manually tested the change as given in the PR description as of now . I am working on a separate [PR to enable Oracle test classes](https://github.com/prestodb/presto/pull/25762). I'd like to get...

> @namya28 what is the state of this review? Hi @tdcmeehan , I've addressed the test case failures for the two test classes in this PR. However, the third test...