splitwise icon indicating copy to clipboard operation
splitwise copied to clipboard

Wrong parameter "friendship_id" for getExpenses

Open quaqo opened this issue 2 years ago • 2 comments

According to API ref v.3.0 the correct parameter should be "friend_id", friendship_id is then returned for getExpense.

Patch below:

./splitwise/init.py

460c460
<                     friendship_id=None,
---
>                     friend_id=None,
471,472c471,472
<             group_id(long, optional): GroupID of the expenses
<             friendship_id(long, optional): FriendshipID of the expenses
---
>             group_id(long, optional): If provided, only expenses in that group will be returned, and friend_id will be ignored.
>             friend_id(long, optional): ID of another user. If provided, only expenses between the current and provided user will be returned.

quaqo avatar Dec 07 '21 09:12 quaqo

Thanks. Let me have a look

namaggarwal avatar Jan 30 '22 12:01 namaggarwal

image

CloCkWeRX avatar Mar 20 '22 06:03 CloCkWeRX

Fixed in v3.0.0.

namaggarwal avatar Jun 19 '23 21:06 namaggarwal