splitwise icon indicating copy to clipboard operation
splitwise copied to clipboard

Proposal: use black, typing, PEP 8

Open technillogue opened this issue 3 years ago • 1 comments

PEP 8

Function names should be lowercase, with words separated by underscores as necessary to improve readability. Variable names follow the same convention as function names. mixedCase is allowed only in contexts where that's already the prevailing style (e.g. threading.py), to retain backwards compatibility.

This is the stuff I already partially have, would prefer for my fork/usage of splitwise, am happy to do but would otherwise keep in my fork, but maybe these would be welcome upstream?

technillogue avatar May 16 '21 19:05 technillogue

The problem with this is that it would be breaking changes. We can maintain function aliases and I would welcome that.

namaggarwal avatar May 18 '21 09:05 namaggarwal