Nalin Dahyabhai
Nalin Dahyabhai
Flaking _a lot_ in a way that's reminiscent of when we needed the change from https://github.com/containers/common/pull/2339.
/packit propose-downstream
Does this include the changes from #6424?
Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations
Yeah, it's used by `tmpdir.ForURL()`, which is meant to replace `define.TempDirForURL()`.
Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations
Moved those bits to a new `internal/httpclient` package.
Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations
Tweaked a bit to expose the proxy setting directly for callers.
> Note if we take this step and formalize things more it actually gets a lot cleaner as the builder can know the ordering here and we can declare that...
I would have (and have previously) suggested solving this at the pipeline level. Anyway, the reason the FROM fails is that the OCI archive is no longer being written to...
> It looks like `bind-propagatation` is a buildah-specific extension not supported by Docker It looks like that flag is there because the set of accepted flags for `buildah run --mount`...
> > I would have (and have previously) suggested solving this at the pipeline level. > > Can you elaborate on that? Previously in [this comment](https://github.com/coreos/rpm-ostree/issues/4688#issuecomment-1802060958) you said: > >...