buildah icon indicating copy to clipboard operation
buildah copied to clipboard

Remove slirp for Podman6

Open lsm5 opened this issue 2 months ago • 8 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For podman6

How to verify it

Verify buildah doesn't work with slirp

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Slirp4netns support has been removed.

Rebased on the cgroups v1 removal PR.

lsm5 avatar Oct 21 '25 16:10 lsm5

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 21 '25 16:10 openshift-ci[bot]

Ephemeral COPR build failed. @containers/packit-build please check.

Does this include the changes from #6424?

nalind avatar Oct 22 '25 19:10 nalind

Does this include the changes from #6424?

I think so. I might need to rebase on main though. Also, one of the crun tests timed out. I retriggered it just now.

lsm5 avatar Oct 23 '25 12:10 lsm5

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Oct 24 '25 22:10 openshift-merge-robot

@lsm needs rebasing

TomSweeneyRedHat avatar Nov 18 '25 22:11 TomSweeneyRedHat

@lsm needs rebasing

@TomSweeneyRedHat lsm is someone else (and he liked the comment :smile:) . Might wanna wait for the suggestions when you start @-ing

lsm5 avatar Nov 19 '25 13:11 lsm5

@lsm5 I can not be held legally responsible for anything that I type before 9:00 in the morning or after 5:00 in the afternoon my time.

@lsm, apologies for the noise!

TomSweeneyRedHat avatar Nov 19 '25 20:11 TomSweeneyRedHat

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Dec 20 '25 00:12 github-actions[bot]