Natalie

Results 13 comments of Natalie

Note: When the repair order is not yet confirmed, the flow seems to go through here: https://github.com/odoo/odoo/blob/a9d2771d3ae19c0685d904ab908c6400e7f2630a/addons/repair/models/repair.py#L542-L554 and I'm not sure I fully understand why we don't have the "same"...

@odoo/rd-logistics Hello :) Could I get a review here please when you have some time?

Seems like in the meanwhile this issue was solved by https://github.com/odoo/odoo/pull/168227. I will close this PR after confirming.

Issue already solved by https://github.com/odoo/odoo/pull/168227

[Note: No longer relevant] I think this is the best fix, even if it makes the runbot go red because we're adding a non-store field for the search, because it...

Maybe for master we can try to remove the `filter_for_expense` field from the 2 children models, and factor it into `hr.employee.base`

Not a huge fan of this fix; but it's the simplest way to not call the update on create and it's unclear how we could detect the skills that are...

Rename branch after 18.0 retarget: https://github.com/odoo/odoo/pull/183158 Note: review taken into account in new PR

You're right about not needing to fiddle with kits but leaving the test as is because I guess more complicated steps than needed are more likely to catch subtle bugs...

> > You're right about not needing to fiddle with kits but leaving the test as is because I guess more complicated steps than needed are more likely to catch...