naiming-zededa
naiming-zededa
Ok, sure. But I see this in the code: darkScheme := map[string]colorInfo{} lightScheme := map[string]colorInfo{} I'm just not sure how to invoke 'dark' or 'light' in this scheme with APIs.
> I have just realised this code doesn't mention Adwaita at all - maybe it was a bad paste? Sorry, you are right. I used to do this: fyneApp.Settings().SetTheme(theme.AdwaitaTheme()) myApp.App...
maybe i misunderstood the AdwaitaTheme, i thought it could be integrated into the fyne theme. but how does it suppose to change between 'darkScheme' and 'lightScheme'?
what i'm seeing is this, it i do: fyneApp.Settings().SetTheme(theme.DarkTheme()) or fyneApp.Settings().SetTheme(theme.LightTheme()) it works, regardless of the host system mode setting but if i'm changing to: fyneApp.Settings().SetTheme(theme.AdwaitaTheme()) or fyneApp.Settings().SetTheme(theme.LightTheme()) what i'm...
but I would think more specific should always overwrite the less specific. If my app has a button to turn it to 'dark' mode, then regardless of the global setting,...
@alicefr the PR is updated. thanks. /retest
Hi @xpivarc @alicefr , anything else you can think of I need to do for this PR? thanks.
@xpivarc are you ok with the explanation above? We had a similar PR/upstream commit in Longhorn: https://github.com/longhorn/go-iscsi-helper/pull/63, which merged in longhorn release v1.4.2 Also some examples on a real host...
hi, @alicefr @xpivarc , i'm not sure how to move this forward. what do you think we need to do here? thanks.
/retest-required