Noah Gilson
Noah Gilson
> Will --configuration override this? @KalleOlaviNiemitalo That's a good point -- it should override this. If a user has `Debug` we don't want to replace that. Thanks for asking that...
@dsplaisted Thank you for reviewing this large thing. I responded to all of your comments and resolved everything I fixed. The remaining ~3 could be followed up. Then lmk if...
> Can you change the name of the ENV? It is pretty non-standard. Also, long ENVs are fine. > > `ENABLE_P_RELEASE_SLN` -> `DOTNET_PUBLISH_RELEASE_SLN` That is also one of Daniel's remaining...
OK to merge once approved ✔️
> Sorry for another flood of feedback, but this is actually looking good. 👍 Thanks 🙂 Actually, I love getting feedback like this because it's the best way to learn...
All of the requested changes are in @dsplaisted though we want this to go into 7.0.100 as well, it seems this is going to pick up other depended upon changes...
@dsplaisted removed the commits that came in after 7.0.100 retargeting.
@dsplaisted Removed the project locator class 👍
This is ready, but we are working on higher priority items atm.
@joeloff Thanks for taking another look, please approve if OK. FYI this is what the err looks like in terminal 