Pavan Kunisetty
Pavan Kunisetty
I am interested in contributing. I am using the package for work.
Any timeline on merging this PR?
@maxmil7 Looks like checks have passed. Can you merge the PR?
+1 Same issue with Sierra as well.
Agreed. Usually license will be added as a file and the same will be picked by GIT by default.
+1 Having the similar problem in testing S3 getObject as stream.
I got the issue fixed. From the `aws-sdk-mock` code, we have to return a Buffer instead of readStream to get the mock done. Please try following: ```javascript awsMock.mock("S3", "getObject", new...
I am not sure if callback works in this case. Can you try following? ```javascript awsMock.mock("S3", "getObject",(params, callback) =>{ callback(new Buffer(require("fs").readFileSync(params.fileName))) }); ```
My apologies, Code wouldn't allow that to work: ```js createReadStream() { const stream = new Readable(); stream._read = function (size) { if (typeof (replace) === 'string' || Buffer.isBuffer(replace)) { this.push(replace);...