Michael Montgomery

Results 46 comments of Michael Montgomery

@thbkrkr meant to update yesterday. The permission errors were from attempting to use `/usr/share/filebeat-sidecar` as the path for the filbeat sidecar, which was unnecessary. I removed that from the config...

@thbkrkr There were additional issues found surrounding sidecar permissions reading the unix socket. These were resolved, and tests were added around this feature. It's again ready for 👀

> I think we have a usability issue here with some of the existing recipes using the `-e` option. We can assume that some of our users also might have...

@pebrc documentation added. Let me know how you feel about the wording.

> make the whole RBAC side of deploying agent easier with the Helm chart I would love to make this easier for the user, but I'm not sure the Helm...

We met and had a discussion about the current implementation, vs a more specialized implementation for, say, Fleet, and comparing what the user experience was like between the two, we...

@pebrc Update: Both Elastic Agent, and Elastic Fleet Server Agent helm charts are now included in this PR, and are ready for review.

> Is it intentional that labels/annotations are managed differently in the ClusterRoleBinding/ClusterRole/ServiceAccount between the two charts? The eck-agent chart supports dedicated labels/annotations but for labels we also get the labels...

@thbkrkr While adding tests, I noticed that `.Values.[labels|annotations]`, and `.Values.[serviceaccount|clusterRole|clusterRoleBinding].[labels|annotations]` weren't both making it into the rendered templates, and this was fixed, and tests were added for all.

After thinking this through more, how would this be faster than updating the change budget to be the maximum number of nodes that could safely be upgraded at a time...