Nadim Islam

Results 28 comments of Nadim Islam

Try to avoid passing the component with arrow functions or binding them in the render function. Otherwise 1000 rows is pretty extensive. A proper solution would be to use `react-virtualized`...

Redux shouldn't cause any issue here, can you create a short code sample to show the error? The values should just be passed to the component normally

Sorry @nick318, this repo is not really maintained but for whoever finds this: You need to initialize empty data matrix and pass it on to the data field ``` ```

hey @patwalls, this is currently used in production with a similar dataset size. However, it definitely is not optimized for performance out of the box. This is especially true when...

@lukas1994 Sorry have not been actively maintaining this repo. I'll look into it this weekend as well. In the meantime, would you have a JSfiddle I can use.

Sorry for the late reply @lukas1994, I had some time to look into this but only at a surface level. See the following branch and let me know if this...

> @nadbm , thanks for looking at this. Let me know if I can help in anyway. I use this library too and appreciate the simple and flexible api. I...

@a-pachkov Your example had a simple fix: valueRenderer was using dynamic function so memorization wasn't happening. Here's a fixed version I uploaded https://github.com/nadbm/perf-test-rd And here's the commit that changed from...

@a-pachkov I think that will require a little bit more rework on the library's end. I will investigate further this weekend

I like the idea. I'm thinking something like this: ```javascript enterEditModeOnKeyPress={true|false|(key, cell) => bool} ``` What do you think @orangedonkey