Nabeel S

I think I can make a fairly safe tweak to the chart to allow you to test this: https://github.com/nabsul/k8s-ecr-login-renew/pull/53/files

helm chart is published.

Actually, you might also want to change the docker image to the latest one here: https://hub.docker.com/layers/nabsul/k8s-ecr-login-renew/sha-adba342/images/sha256-b55d183b333eeebaff8affdb446601b63d7c76829974f0ee487aab2a843b35db?context=explore It has all the latest dependency updates. I'm not sure if the current official...

Very cool, thanks! I'll try to get this reviewed and merged as soon as I have some time.

Hi, I know it's been quite a while, but life is extra busy at the moment :-). But I haven't forgotten about this! I believe things will start to free...

Wow! Thanks for this contribution @ptik31. I looked over the change, and it's all clean and concise. And thank you for the code quality improvements as well (unused using, wrong...

Alrighty! I'll try to get everything tested and released in the next few days.

Good timing, this is a change I can make in the next release that I'm preparing.

I think I'll simply do both: The annotation and the ingressClass, to cover both scenarios. I don't think it will hurt anything to have both.

Implemented in: https://github.com/nabsul/kcert/pull/60/commits/95b060f7a49eb49b74adfff5fd74d3cd94ba7a7a