kcert
kcert copied to clipboard
Ptik31/await ingress propagation
Use of test endpoint to wait for challenge ingress propagated completely
Very cool, thanks! I'll try to get this reviewed and merged as soon as I have some time.
Hi, I know it's been quite a while, but life is extra busy at the moment :-).
But I haven't forgotten about this! I believe things will start to free up for me in about 2 weeks. Then, I need to wrap up the PRs that I already have on this project, and this PR will be next. Thank you for your patience, and I really do appreciate the contribution!
Hi, thank you for keeping me up to date. Please don't worry about us, we temporarely switched to our own docker image built from your awesome dockerfile :)
All the best
Hi @nabsul , thats a really great idea. I was investigating it and found these possible approaches:
After successful setting up the newly created ingress, the controller adds the following properties to the ressource manifest:
- manager
- load-balancer.ingress.ip
I'll inform you after my changes are done to review them again.
Please let me know if you suggest further exploring.
Hi @nabsul , I've implemented the loadbalancer approach. You can review now.. Let me know about other findings or ideas.
Wow! Thanks for this contribution @ptik31. I looked over the change, and it's all clean and concise. And thank you for the code quality improvements as well (unused using, wrong LogError, etc.).
The change looks completely reasonable. I will just need to find time to carefully review the new function and test it. Hopefully this week or weekend, but it could take a few weeks if things get too busy.
@nabsul, your turn. Pls take as many review turns as you need to approve :)
Alrighty! I'll try to get everything tested and released in the next few days.
Great, thank you for the great collaboration :)