kcert icon indicating copy to clipboard operation
kcert copied to clipboard

Ptik31/await ingress propagation

Open ptik31 opened this issue 2 years ago • 4 comments

ptik31 avatar Jul 12 '22 14:07 ptik31

Use of test endpoint to wait for challenge ingress propagated completely

ptik31 avatar Jul 12 '22 14:07 ptik31

Very cool, thanks! I'll try to get this reviewed and merged as soon as I have some time.

nabsul avatar Jul 12 '22 15:07 nabsul

Hi, I know it's been quite a while, but life is extra busy at the moment :-).

But I haven't forgotten about this! I believe things will start to free up for me in about 2 weeks. Then, I need to wrap up the PRs that I already have on this project, and this PR will be next. Thank you for your patience, and I really do appreciate the contribution!

nabsul avatar Aug 07 '22 15:08 nabsul

Hi, thank you for keeping me up to date. Please don't worry about us, we temporarely switched to our own docker image built from your awesome dockerfile :)

All the best

ptik31 avatar Sep 08 '22 05:09 ptik31

Hi @nabsul , thats a really great idea. I was investigating it and found these possible approaches:

After successful setting up the newly created ingress, the controller adds the following properties to the ressource manifest:

  • manager
  • load-balancer.ingress.ip

image

I'll inform you after my changes are done to review them again.

Please let me know if you suggest further exploring.

ptik31 avatar Nov 17 '22 07:11 ptik31

Hi @nabsul , I've implemented the loadbalancer approach. You can review now.. Let me know about other findings or ideas.

ptik31 avatar Nov 17 '22 07:11 ptik31

Wow! Thanks for this contribution @ptik31. I looked over the change, and it's all clean and concise. And thank you for the code quality improvements as well (unused using, wrong LogError, etc.).

The change looks completely reasonable. I will just need to find time to carefully review the new function and test it. Hopefully this week or weekend, but it could take a few weeks if things get too busy.

nabsul avatar Nov 21 '22 14:11 nabsul

@nabsul, your turn. Pls take as many review turns as you need to approve :)

ptik31 avatar Nov 23 '22 05:11 ptik31

Alrighty! I'll try to get everything tested and released in the next few days.

nabsul avatar Nov 24 '22 00:11 nabsul

Great, thank you for the great collaboration :)

ptik31 avatar Nov 24 '22 05:11 ptik31