Nabil Freij
Nabil Freij
This turns into a please update parfive to 2.0 in the whatsnew.
This has now been updated to mention parfive 2.0.0 in the whatsnew, with no change to the min version of parfive. As thing stand, sunpy still supports both.
> I think this is also worth calling out in the release announcements and stuff (i.e. when we give out pip install commands also add parfive)? :+1:
I don't know if there will be sunpy users using Pyodide, but I can spend some time in the next few weeks trying to get this working upstream.
If it's being stored anywhere it belongs in a nice rst doc file.
> That doesn't seem practical in terms of format or maintenance. Authorship is naturally coupled with individual code files, so creating and maintaining a separate list of authorships is even...
>I don't necessarily have objections to authorship information being removed, but I strongly dislike the offered justifications: that Git history is a competent substitute (it isn't), and that we're too...
> This is looking good. There are several bits where you've said "To be restored elsewhere.". Could you revert these changes (or I can?) so we can: > > *...
> Fab - sorry for reviewing before this was ready 😃 Important to review even before its ready.
> What's the status here? Looks like there's some not very nice rebases to do now. (as always!) I'd advocate for doing these in lots of small bitesized PRs so...