Nabil Freij

Results 905 comments of Nabil Freij

Good question, I don't think we have made any changes to the database module that I can recall in some time. Considering we plan to replace database with a new...

I personally would argue this is a bugfix, not taking account of masked values correctly.

> This needs to remove the compatibility layer from utils/parfive. fixed

> I think there's some code somewhere which passes headers in or something. We should run the tests. Ahead of you.

We can just add parfive to that list.

I can do that in this PR?

> * A good reason (which I don't see here - it wouldn't be too hard to support parfive 1 and 2 right?) We want to ensure that people have...