Nathan Agrin
Nathan Agrin
This solved a bug I had with ng-repeats and containers / models not being cleaned up. Can I help get this into master? What needs to be done here? Repro...
We hit this too. There was no way we could fix. Running node-gyp did not fix the problem.
We resolved this a short time ago. Turned out my coworker who was hitting this problem had a rogue, custom build of make in his path. Sorry for the confusion.
I'm having the same problem you describe @Roustalski. I wrote up an attempt at a repro here https://github.com/Microsoft/TypeScript/pull/24071#issuecomment-402849519 FWIW your solution does work for me, but I'd much rather not...
The issue stems from this line https://github.com/SheetJS/ssf/commit/d273a28d54b3f0478e568e59b0d9159c68a8731d#diff-2bf8a02964fc7c103bafd1eea1a85abdL126
I spent several hours yesterday trying to dig into this and come up with a fix, but was ultimately defeated by the complexity of the code. @SheetJSDev do you guys...
@machour thanks for taking a look. This fails locally for me consistently, let me try to get it failing for your ci
@machour getting this to fail on CI was tricky. I have not been able to reproduce the case where javascript throws an exception, complaining `TypeError: Cannot destructure property 'default' of...
@machour thank you! @mcansh @brophdawg11 I've separated the failure cases into two tests. Hopefully you are able to reproduce locally and see the errors described above. Please feel free to...
I still believe this is an issue. I will update the repro case against latest remix version