Zhenxiang Ma
Zhenxiang Ma
Thank you for your detailed review again!I have fixed some naming problems and now make sure the pytest will work.However,with only TN part I have designed,it may be difficult for...
> > Thank you for your detailed review again!I have fixed some naming problems and now make sure the pytest will work.However,with only TN part I have designed,it may be...
> > > > Thank you for your detailed review again!I have fixed some naming problems and now make sure the pytest will work.However,with only TN part I have designed,it...
> > > > > > Thank you for your detailed review again!I have fixed some naming problems and now make sure the pytest will work.However,with only TN part I...
The local setup fix nothing for current code but I can't pass CI test this time. Is it because I changed something in tools/text_processing_deployment?
> `他说:“我们已经吃过了!”。` => `他说比“我们已经吃过了!”。` `这儿有只鸟儿` => `normalize.py", line 363, in _permute raise ValueError()` Thank you!I have fixed it.
> Could you please try to fix the alerts as described here: https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f0d82e6d82662b60dc1c597bc403b4ac6dc1615a? Thanks. Ok,I have deleted the useless lines in the lastest commit