Martin Zumsande

re-ACK 3add23454624c4c79c9eebc060b6fbed4e3131a7

This seems to be a misunderstanding. I don't think that this PR fixes a bug, the sentence in question referred to the older PR #16577 which is already merged.

ACK 59aa54f7312f3441692c89feed86b8756d9d6b7a (verified via range-diff that just a typo / `unique_ptr` initialisation were fixed)

Post-Merge comment: There is no longer a `-i2ptransientout` option, it was forgotten to update the PR description according to the discussion. Since people will refer to this PR (e.g. in...

Looks like the regtest DNS seed `dummySeed.invalid.` (which is meant to be invalid, see https://github.com/bitcoin/bitcoin/pull/22098#issuecomment-888648789 for original motivation) resolves to `1.0.0.1` on your system for some reason.

I tried to reproduce this (Ubuntu 20.04.4 LTS) with a large wallet but could not see a memory leak (also not with valgrind). What I did see is that repeated...

A very interesting long-term solution (not just for this problem, it would have several other benefits) would be to have a separate addrman for each network instead of one shared...

> What is the reasoning behind 1.2? Would it not benefit the network to have better gossiped addresses, especially for networks like I2P and CJDNS? The general idea that addresses...

> @mzumsande I've been trying to reproduce this by modifying the syncchain method, but as far as I can tell, interrupt logic seems to be working as expected. Can you...

> Any suggestion about which commits would be good to include in a smaller initial PR? Maybe the first 7 commits, which mostly reduce the use of internal types within...