Michael Zhang comments

Repositories
Issues
Comments

Results 3 comments of


                                            Michael Zhang

planner: use ordered index with is null predicate

Please ignore this PR and review https://github.com/pingcap/tidb/pull/54290 instead.

SHOW COLLATION format does not compatible with mysql 8.0

This is about the output format of `SHOW COLLATION` command. mysql returns 7 columns, tidb returns only 6 columns.

tiup leaks credential through environment printing

I think code is here: https://github.com/pingcap/tiup/blob/c1a14a55118b5c2076497cca7d7b28741ad8ab80/components/cluster/command/root.go#L278 and https://github.com/pingcap/tiup/blob/c1a14a55118b5c2076497cca7d7b28741ad8ab80/components/dm/command/root.go#L235 There is no where in tiup that user can set log level. By default this debug information should not write to file.