Marek Mytkowski
Marek Mytkowski
Previously, I used `std::function` as the return type for the getter, but the performance was pretty bad. I changed O2 to debug mode and used perf + speedscope to analyze...
@ktf @jgrosseo, May you have a look at the latest changes?
@ktf I have finally made the changes requested in your last review. Could you take a look at the current implementation?
@ktf I simplified this using `nullptr` as you advised; now I wonder if this `strncmp` in my implementation is not making it overcomplicated for such a comparison. Could you take...
Good morning @ktf, Could you review the changes from 2 weeks ago and answer my comment? I will be grateful!
@ktf Would you have time to take a look at this PR once more?
The `string_view` API has an efficient `starts_with()` method, which would check exactly the case I want to handle and it is very readable. Then I think that creating `string_view` from...
@ktf I have rebased PR, and now all checks are successful.