mythsman

AdbMonitor may fail to track devices when many devices get online or offline at the same time.

8

https://github.com/Genymobile/gnirehtet/blob/f5c0710c751f7ca82ce413058abc57d9af7208c3/relay-java/src/main/java/com/genymobile/gnirehtet/AdbMonitor.java#L152 Here I think an exception should be raised to reset the current state...

I think it is a good idea to customize the placeholder in the comment box , like changing 'You comment here' to something different which i can easily configure ?

It seems not a standard ddqn implementation.

3

https://github.com/YangRui2015/2048_env/blob/2e9b3938492e4f7a0a2b627b8607ad1c203d273a/dqn_agent.py#L96 I was new to DQN , and confused with this line . And it should be `q_eval_4_next_state_argmax` instead of `q_eval_4_this_state_argmax` , right ?