MithunR comments

Results 156 comments of


                                            MithunR

[QST] Changing `cudf::rolling_window` API to have exclusive `preceding` parameter

At the risk of repeating what @codereport covered in the description, I can try provide a summary: Window bounds are defined in CUDF via a "preceding" and "following" row-count. For...

[REVIEW][Java] Bindings, tests and benchmarks for RMM pooled memory

I've merged #1510, which seems to have introduced conflicts in the `CagraBuildAndSearchIT.java` file.

[REVIEW][Java] Bindings, tests and benchmarks for RMM pooled memory

I've taken @rapidsai/cuvs-python-codeowners, @rapidsai/ci-codeowners, etc. off of this review. The changes are all in Java, and straightforward.

[REVIEW][Java] Bindings, tests and benchmarks for RMM pooled memory

/ok to test d74f38e

[REVIEW][Java] Bindings, tests and benchmarks for RMM pooled memory

/ok to test bd8670a

[REVIEW][Java] Bindings, tests and benchmarks for RMM pooled memory

Hmm. Odd C++ [compile error](https://github.com/rapidsai/cuvs/actions/runs/19555125757/job/55995879836?pr=1453): ``` /home/coder/cuvs/cpp/build/pip/cuda-13.0/release/_deps/raft-src/cpp/include/raft/cluster/kmeans.cuh(97): error: SamplingOp is not a template SamplingOp& select_op, ``` Included from `kmeans_common.cuh`, and it's certainly a class-template.