Mark Logan

Possible work around for consensus issues

1

This PR is intended as a discussion topic, not as mergeable code. If we decide to go with this approach, we should take a slightly more principled approach in which...

Use execution driver instead of sync_authority_source_to_destination for gossip

1

This improves parallelism, and removes the use of the (slightly) incorrect `sync_authority_source_to_destination`

Invoke Cunningham's law

2

I've written a bunch of comments about consistency requirements in authority_store.rs as an effort to understand this code better. Please let me know what I've gotten wrong.

AuthorityHealth should be shared with AuthorityAggrator in order to better cope with degraded network conditions. See: https://github.com/MystenLabs/sui/blob/main/crates/sui-core/src/authority_active.rs#L72 Todos: - [ ] AuthorityAggregator::new takes an Arc arg, which may be owned...

I believe we are currently experiencing the following issue: - LB opens connection to backend to service request - LB keeps connection open for some period of time even if...

We recently saw the following error in fullnode logs: `2022-10-20T01:22:24.254751343Z stderr F 2022-10-20T01:22:24.254662Z ERROR sui_core::safe_client: Client error in handle_batch_stream err=ByzantineAuthoritySuspicion { authority: k#85fef58e41c9ad8e6779c333a65425e13889605e04cbf47bfc47f78650b24207b66104d3cab448b12c125202f2578d95144aa757419ab8c02a7649981cc71589954df6e3ced405a88f1efc0a8b756db1086dddba7d2d92dcb7218f1094e895af, reason: "Inconsistent batch" } authority=k#85fef58e41c9ad8e6779c333a65425e13889605e04cbf47bfc47f78650b24207b66104d3cab448b12c125202f2578d95144aa757419ab8c02a7649981cc71589954df6e3ced405a88f1efc0a8b756db1086dddba7d2d92dcb7218f1094e895af` The most...

Use type system to indicate signatures have been verified

2

The goal of this PR is to safely support optimizations that reduce unnecessary signature verifications. For instance, before this PR, we would verify signatures after loading a cert from the...

A module for shutting down tasks easily

2

The motivation for this is that we would like to forcibly cancel all ActiveAuthority processes during reconfiguration. Currently, it is possible for active processes to observe intermediate states during reconfiguration...