Paul Jolly

Results 688 comments of Paul Jolly

Thanks for raising this and apologies, we are aware of the fact that API is not consistent in this respect (https://github.com/cue-lang/cue/issues/1735, https://github.com/cue-lang/cue/issues/1561, https://github.com/cue-lang/cue/issues/1015). For now you can work around this...

@FogDong - ah that API does need to be updated to use [`cue.InstanceOrValue`](https://pkg.go.dev/cuelang.org/go/cue#InstanceOrValue) (a special transition type). We will submit a fix for that.

FYI @rogpeppe is going to help looking at fixing up these bits of the API.

@jbcpollak I'll leave to @rogpeppe to comment. Thanks for your patience!

> One useful invariant to consider: `cue(a, b) & a` would be exactly the same as `cue(a, b)`. I assume you mean `cut()` here? I'm not clear that the first...

Looks like a [label function setting of `AnyWithBlock`](https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_function) would work, but given that config field is deprecated perhaps we make the switch to [submit requirements](https://gerrit-review.googlesource.com/Documentation/config-submit-requirements.html) as part of this change?

Perhaps we first move away from defining the entire [workflow as `bash`-based](https://github.com/cue-lang/cue/blob/0a46a1624353da7327d356040a5612251e01659f/internal/ci/github/trybot.cue#L22) and instead do the "standard" thing per platform? That would flush out the tests that are broken.

I will leave @mpvl to review the change itself, @kcburge, but just a comment on the DCO. The only requirement to assert the DCO is to include the trailer `Signed-off-by`...

@mvdan strange. Not sure what's going on here, because it looks ok to me. Indeed `git` can also log the trailer: ``` git log --pretty='%h %an %(trailers:key=Signed-off-by)' ``` @kcburge -...