Paul Jolly

Results 688 comments of Paul Jolly

The ultimate cause here is the disjunctions for `#job` and `#job_template`, which contain open structs. Hence, according to the current disjunction elimination algorithm, there are many potential "correct" answers, CUE...

@xinau yep, that's absolutely what I intended. Thanks for spotting the mistake. I've updated my example accordingly just in case.

Still appears to be an issue as of 8a7ebf930b080ab9d14d8d23755d2ec39d1194b1. However, I will note that this test is somewhat limited.

No worries, @c-kruse! I updated the description with a self-contained repro for ease of checking/fixing this issue. We have a [wiki](https://github.com/cue-lang/cue/wiki/Creating-test-or-performance-reproducers) which gives tips on how to easily create such...

Thanks @yangzhares - I'll defer to @mpvl for a review here. In the meantime, please can you take a look at the contribution guide on commit messages? https://github.com/cue-lang/cue/blob/master/doc/contribute.md#good-commit-messages That gives...

> Changing the import mechanics could break a lot of existing code Just to be clear, that is not my proposal. We cannot break the import behaviour nor do I...

I vaguely remember this coming up at the time we introduced tag vars. Sounds good to me. But I defer to @mpvl for a final decision.

I suspect that part of the solution here will involve defining exactly what kinds of errors can be ignored. That will likely become easier as part of #822.

Noting that this broke as far back as 7f52c107b61980629c4c0d6751386a8ce360ddb9, but was masked by a bad fix in https://cue-review.googlesource.com/c/cue/+/6081.

This should not have been closed. Naughty GitHub.