Imran Iqbal

Results 67 comments of Imran Iqbal

@dafyddj That's very kind of you to offer, I appreciate it.

Thanks @aboe76. We're going to merge https://github.com/saltstack-formulas/template-formula/pull/175 soon, spread those changes to all of the formulas including this one and then revisit this PR again, rebased.

@aboe76 I'm almost done with https://github.com/saltstack-formulas/template-formula/pull/175. I'm going to run tests on all formulas in my own forks in Travis, to make sure the propagation is going to work as...

@bbilyeu Regarding the failing `commitlint` job: ```console ⧗ input: style(*): Added vim modelines Adding simple vim modelines for convenience. ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖...

@bbilyeu Actually, when you amend the commit, would you mind rebasing this PR on the latest commit to this repo? That will use the updated CI matrix.

> I apologize, but my rebase knowledge/experience is embarrassingly weak. Would amending the commit and rebasing not bloat the commit history with duplicates? @bbilyeu No, it's an expected (and usually...

@bbilyeu I've just noticed that the very last commit message needs to be updated as well: ```diff -Update snmp/macros.jinja +fix(macros.jinja): fix macro `v3_createUser_string` whitespace control ```