Imran Iqbal

Results 67 comments of Imran Iqbal

@ixs First bit of feedback. --- This was enough to trigger the error: https://github.com/myii/bind-formula/commit/485880a638c2b605e56113e142362b5e7e735815. https://travis-ci.org/github/myii/bind-formula/builds/670517157: All of the tracebacks in the failing job returned back to [this line](https://travis-ci.org/github/myii/bind-formula/jobs/670517158#L1397), which isn't...

https://github.com/saltstack-formulas/users-formula/pull/219#issuecomment-629973311 Relevant here as well, that `.items()|sort` results in the same error as `|dictsort`.

> @myii just saw now that you pinged me on this issue! Do you still need me to look at something? (FYI we don't use this formula, just an old...

@darkpixel Appreciate the report, would you mind preparing a PR, similar to the one that upgraded to `bind911` a couple of years back (#91)?

> oh, well smile Then, if you can add those 2 lines @daks suggested in the `pillar.example` and ammend the commit subject, we'll be OK to merge. Thanks! @javierbertoli Was...

@ixs Thanks for the PR. It would be helpful if you can adjust the commit message title to something like: ```diff -Update 00-mpm.conf.jinja +fix(00-mpm.conf.jinja): update RedHat template ``` That will...

@bebosudo Please continue your good work. We're making substantial changes across all SaltStack Formulas right now, to improve the quality and consistency of formulas. For example of some of the...

@aboe76 Our changes are going to take some time, perhaps we should put this in a new `develop-v1.0.0` branch, like has been done for the [`apache-formula`](https://github.com/saltstack-formulas/apache-formula/tree/develop-v1.0.0)? One other thought about...

Thanks, @aboe76. @bebosudo OK, I've [created that branch](https://github.com/saltstack-formulas/django-formula/tree/develop-v1.0.0). Feel free to "replace" it with your formula in a new PR.

@bebosudo Are you still interesting in providing this? We could continue with the branch or we could even implement `semantic-release` in this formula, to make it available immediately. * https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst#semantic-release-formulas...