Maxou
Maxou
any idea why this warning pops up and fails only on certain platforms ?
> Please fix all the warnings first from CI. It seems like frrbot wants me to write `struct bgp * bgp` in my hook declaration (bgpd_route.c line 106) while the...
Just noticed I also get warnings about things I didn't write or change, that are from the original frr bmp implementation e.g. : ``` < WARNING: C99 // comments do...
@pguibert6WIND > * rebase to origin/master (especially for [b74844e](https://github.com/FRRouting/frr/commit/b74844edb21a267f06ff3113274166649217c9e2)) i think the branch is already rebased on top of (at least) e7e1561 of origin/master. also commit cd6c698 includes the changes...
@ton31337 would you prefer if i squash them together?
@ton31337 @riw777 done. happy new year btw
> Also2: I don't get it why https://github.com/FRRouting/frr/commit/fa98a15ce02814d7313eba11fef84cdaab76fff3 commit is a separate from the main commit where the main locking/unlocking for path info happens? This commit fixes (thanks to @donaldsharp)...
@riw777 yes. i think i addressed every comment i had at this point, no? i just keep fixing merge conflicts
there were lots of conflicts let's hope i didn't mess something up