frr icon indicating copy to clipboard operation
frr copied to clipboard

Published 20 hours ago • verified publisher icon FRRouting

BMP Adj-RIB-Out (RFC8671), ECMP Support and Loc-RIB missing features

Open mxyns opened this issue 1 year ago • 23 comments

Global:

  • added peer type for all monitored ribs
  • added peer distinguisher for all monitored ribs
  • include mpls labels (when possible, no adj-in-pre)

Add support for Adj-RIB-Out monitoring in BMP:

  • pre- and post-policy
  • config knobs
  • sync
  • incremental updates
  • stats (when possible)
  • no timestamp (currently not recorded in adj-out)

Add ECMP support in BMP:

  • include addpath id in bmp in adj-in pre/post, loc-rib and adj-out pre/post
  • monitoring on all ecmp selected path (BGP_PATH_SELECTED | BGP_PATH_MULTIPATH)

Add Loc-RIB missing features:

  • peer up/down on vrf state update
  • missing stats

Missing:

  • ?

mxyns avatar Nov 21 '23 12:11 mxyns

ci:rerun

mxyns avatar Nov 28 '23 19:11 mxyns

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 29 '23 08:11 github-actions[bot]

@ton31337 would you prefer if i squash them together?

mxyns avatar Dec 12 '23 16:12 mxyns

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 17 '23 18:12 github-actions[bot]

@ton31337 would you prefer if i squash them together?

Yes, please do ...

riw777 avatar Dec 19 '23 22:12 riw777

@ton31337 @riw777 done. happy new year btw

mxyns avatar Jan 04 '24 12:01 mxyns

Also2: I don't get it why https://github.com/FRRouting/frr/commit/fa98a15ce02814d7313eba11fef84cdaab76fff3 commit is a separate from the main commit where the main locking/unlocking for path info happens?

This commit fixes (thanks to @donaldsharp) an issue that only happens when the bmp module is loaded. I think it is interesting to keep it separate because it shows that the code looks like it does because of this issue.

mxyns avatar Jan 09 '24 18:01 mxyns

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 22 '24 14:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 28 '24 09:02 github-actions[bot]

@mxyns still working on this?

riw777 avatar Mar 19 '24 13:03 riw777

@riw777 yes. i think i addressed every comment i had at this point, no? i just keep fixing merge conflicts

mxyns avatar Mar 21 '24 10:03 mxyns

CI:rerun Rerun after fixing git access on CI infra

mwinter-osr avatar Mar 21 '24 14:03 mwinter-osr

there were lots of conflicts let's hope i didn't mess something up

mxyns avatar Mar 25 '24 17:03 mxyns

ci:rerun

mxyns avatar Apr 08 '24 14:04 mxyns

looks like some related ci failures yet ...

riw777 avatar Apr 16 '24 11:04 riw777

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 16 '24 11:04 github-actions[bot]

looks like some related ci failures yet ...

i only see convergence and unrelated evpn issues, isn't it?

now i have conflics again though...

mxyns avatar May 07 '24 11:05 mxyns

@riw777 ci still not passing but the failing tests look to me like they are not related to the changes, any opinion?

mxyns avatar May 13 '24 12:05 mxyns

looks good, just need to sort topo

Great thanks. Any idea how ? Most of these are convergence time issues..

mxyns avatar May 28 '24 14:05 mxyns

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 06 '24 20:06 github-actions[bot]

I guess we need to fix the conflicts now before we can get back to the failures ... rebasing might help with the ci failures anyway

riw777 avatar Aug 14 '24 22:08 riw777

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 15 '24 17:08 github-actions[bot]