Max Stoiber

Results 289 comments of Max Stoiber

The only thing that'd have to change is this line I think: https://github.com/styled-components/babel-plugin-styled-components/blob/856419ba16a5a5002fa60bfe024ae1a3e7b59fac/src/utils/detectors.js#L11 The option should be called `moduleName` in order to stay consistent with the stylelint-processor options. (ref PR...

Feel free to send a PR, cleaner code is always better!

A dang, I had that fixed for a while but it seems like that code went missing somewhere!

I'll publish this under a tag—one second...

``` yarn add --dev babel-plugin-styled-components@experimental ```

We probably just need another check here to make sure we aren't transpiling `styled.keyframes`: https://github.com/styled-components/babel-plugin-styled-components/blob/e3829d28f2b460e097f1499f6091a52b667ef1b4/src/visitors/displayNameAndId.js#L142

We could probably just filter `styled.keyframes` from https://github.com/styled-components/babel-plugin-styled-components/blob/master/src/utils/detectors.js?

Hmm, I think we could support this. Mind adding a failing test case based on the other tests? That'd be super helpful, thanks!

> Because otherwise the detection code would get ridiculous. I don't understand, what does the detection have to do anything? We already check that there's an import from `styled-components` and...

Sorry? He's importing from `styled-components` though? I don't 100% understand what you're saying.