Max Stoiber

Results 289 comments of Max Stoiber

I see, that makes sense! This breaks for me on any code block that has > 1 line of code, see this recording: https://www.dropbox.com/s/qspu16vnb2zrrjr/remove-tab-bug.mov?dl=0 Mind fixing that and adding some...

Whenever @cbeninati adds stuff to the docs!

It doesn't seem to detect tab size based on the rest of the code? ![Recording of broken shift+tab behavior](https://i.imgur.com/oKXwoKY.gif) Note how pressing "Backspace" does the right thing (removes the indentation)...

The logic behind `getIndentation` is that not everybody indents with two spaces. Imagine code like this, `|` is the cursor position: ```JS function bla2(x) { const a = "b"; |...

Yep, we just choose some default and then try and smartly guess the indentation preferences of the user based on their previous code in the code block! So rather than...

Let's just make 2 the default, I prefer that anyway, and then infer from the user if possible.

If I understand this correctly, when you're in an empty code block with the cursor at the first line, i.e. like so: (where `|` is the cursor position) ``` |...

Ohhh I see, that's annoying, great catch! Let's get some tests in here to make sure this doesn't happen again accidentally, and then let's ship it :rocket:

Awesome, thank you! There's a bunch of tests already, you can just model them after that 👌