Max Stoiber

Results 289 comments of Max Stoiber

This should really just be passing through the entire`jwt.sign` options object, rather than specifically the expiresIn time. If we make that change, I'm happy to add this!

The callbackURL has to be absolute, something like: `https://mysite.com/member/fan/register/twitter/return`. You then have to copy and paste that exact URL into your Twitter Apps settings under "Callback URLs". Yes, it's very...

I love it! I think we'll also need a configuration key for the `app.post("/auth/magiclogin")` path. I wonder if we should just have a single configuration key for the root path...

I was also thinking that! What if we did the following: ```JS const config = { path: `/auth/magiclogin` // Will create expand internally } // If the user wants more...

I prefer the former API (with the `path` configuration)! If you want to open a PR for that that'd be excellent ✨ Thank you!

Adding express as a devDependency & peerDependency would be perfect!

I actually kinda like that! I wonder if we can just build a core module that works with plain HTTP and then add "enhancers" on top, while keeping the usage...

I use passport outside of Express with Next.js, but they have very similar `req/res` objects 😬 If it's simple to make it work without Express let's do that, if it's...

All good! Will keep this open in case anybody else wants to tackle this / you end up having time to do it!

@schickling I am still getting `t.model` and `t.crud` are not methods errors :confused: How do I make the Prisma v2 preview work? What am I missing?