Maksym Pavlenko
Maksym Pavlenko
Ah, `go.sum` outdates pretty quickly. @samuelkarp do you want to LGTM this before another rebase, so we can merge right after?
Looks like there are merge conflicts. Could you pls rebase?
This API is currently experimental. With `ENABLE_CRI_SANDBOXES=1` a shim must implement Sandbox API (e.g. take care of sandbox management). We currently don't implement that in runc shim.
Sandbox API in 1.7/2.0 is mostly CRI side refactoring to extract pause containers management into a separate package (which is now one of sandbox API implementations). Ideally yes, we should...
@dcantah I think you've played with grpc stuff recently, pls PTAL.
Windows needed workaround 20aebe7c1379e41b9d9ad6305e45489b77b5bbb0. Everything else looks green. > Although would be good to avoid the warning log. @dmcgowan The warning is coming from an extra [call to introspection service](https://github.com/containerd/containerd/blob/ccc41e6705c9f8fd8d1ec9ea2a4b9db2a03e809e/cmd/ctr/commands/client.go#L75)...
Not directly related to this PR, but given that Go 1.18 got native fuzzing, should we eventually migrate to Go's one?
Trying to understand this if statement: ```go if context.Bool("metadata-only") { sopts = append(sopts, image.WithAllMetadata) } else if !context.Bool("skip-metadata") { sopts = append(sopts, image.WithAllMetadata) } ``` we don't need both flags,...
Could you pls rebase the PR against latest changes in `main` to rerun CI?
Hey @Mossaka, can you give a bit more context on `cgroups-rs` vs `libcgroups` ?