rust-extensions icon indicating copy to clipboard operation
rust-extensions copied to clipboard

Feature: shim: Complete the metrics collection for cgroup v1

Open zzzzzzzzzy9 opened this issue 1 year ago • 6 comments

Complete the metrics collection for cgroup v1 so that containerd can obtain complete metrics information

zzzzzzzzzy9 avatar May 27 '24 08:05 zzzzzzzzzy9

@mxpv

zzzzzzzzzy9 avatar May 28 '24 08:05 zzzzzzzzzy9

@Burning1020

zzzzzzzzzy9 avatar May 29 '24 08:05 zzzzzzzzzy9

Got you. Will review it...

Burning1020 avatar May 29 '24 09:05 Burning1020

I think it's great to have a complete cgroupv1 stats collection, but given https://github.com/containerd/rust-extensions/issues/258 suggests that the complex logic of cgroups stats should not reside in the shim crate, I would recommend that we should take a look at if libcgroups could be of use.

In particular, libcgroups maintained by youki has cgroups v1 and v2 StatsProvider (source), so we don't need to duplicate the effort in this repo.

I am fully aware that we are using cgroups-rs, so what I am proposing here is to evaluate whether or not libcgroups satisfies our requirements and can replace cgroups-rs.

CC @utam0k

Mossaka avatar Jun 05 '24 23:06 Mossaka

I'm happy to collaborate with you if possible!

utam0k avatar Jun 07 '24 05:06 utam0k

Hey @Mossaka, can you give a bit more context on cgroups-rs vs libcgroups ?

mxpv avatar Jun 17 '24 20:06 mxpv

Thanks for your work on this! Since the long-term plan is to remove cgroups from the shim crate (see #258), I’m going to close this PR.

mxpv avatar Dec 13 '24 20:12 mxpv