Max Meinhold

Results 24 comments of Max Meinhold

I'm seeing this when I upload PDFs, so it appears like it might be an issue with thumbnail generation. ``` File "gallery/__init__.py", line 181, in upload_file file_model = add_file(filename, dir_path,...

This issue is about uploads, not viewing? Those PDFs are older than this issue.

Is it possible to detect a bad thumbnail source in code? It'd be neat if gallery automatically regenerated the thumbnail, or reinstated the default when a broken one was loaded.

I'm wondering what the value in this definition is. Committees have no powers, and no outline responsibilities. There is noone responsible for appointing a lead, it seems to just _happen_....

Can you also base this against develop? We should only be merging to master when making prod releases, which generally is very risky this time of year, and we prefer...

We pull all the upperclassmen at a couple of points. One is [when creating new packets](https://github.com/ComputerScienceHouse/packet/blob/e5761dc7d331e0b39ae9bbd6e29acd078438baeb/packet/utils.py#L177-L178), another is [in `sync_with_ldap`](https://github.com/ComputerScienceHouse/packet/blob/e5761dc7d331e0b39ae9bbd6e29acd078438baeb/packet/utils.py#L219-L220). Both of these rely on [`get_active_members`](https://github.com/ComputerScienceHouse/packet/blob/e5761dc7d331e0b39ae9bbd6e29acd078438baeb/packet/ldap.py#L106-L111) There are a few...

What about having it load incrementally, or be paginated? I think either would be a bit nicer than just a query limit.

This is _probably_ my fault. I'll take a look and see if I can find it.

We should follow up that revert with _actually_ updating onesignal.

Hmm, how are you thinking you might handle this?