Maximilian Michels
Maximilian Michels
Any thoughts on how and when to proceed with this PR? We'd like to help to bring this over the finish line.
> The next question would be how to squash the commits? If you want to preserve authorship of your changes @mxm, without overwriting authors of the base commits, we would...
> I wouldn't squash all commits into one. The original commits authored by Sebastian, Dawid and Arvid I think are nicely separated. But sure, squashing your fixups to those commits...
@flinkbot run azure
Thank you @pnowojski for your thoughtful comments and guidance. And of course thanks to the original authors @AHeise @dawidwys @smattheis. Whoops @smattheis I had assumed you wouldn't continue on this...
(Rebased)
@flinkbot run azure
Thanks @pnowojski. Will fix those. On another note, do you think it makes sense to add a configuration option to disable using split alignment entirely? I'm a bit worried this...
> There are still some related test failures: > > > Documented option pipeline.watermark-alignment.allow-unaligned-source-splits does not exist. I had to remove the `@Deprecated` flag from the configuration option. Otherwise, it...