Max Inden

protocols/dcutr: Don't retry when incoming direct connection succeeded

2

As of today we retry the DCUtR process when the outgoing direct connection upgrade failed. In the case where the incoming direction connection upgraded succeeded, there is no need for...

core/src/peer_id: Support and output peer IDs as CIDs (RFC 0001)

6

rust-libp2p should implement [RFC 0001](https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md). Tracking issue: https://github.com/libp2p/specs/issues/216 Also tackle: https://github.com/libp2p/rust-libp2p/blob/9f331e517f524dd112bf9e12b26d9dfae9162022/protocols/kad/src/protocol.rs#L102-L104

*: Replace implementations of `Display` and `Error` on errors with `thiserror`

7

I would argue that a generated implementation of `Display` and `Error` via `thiserror` is faster to write and easier to maintain. Thus I advocate for using `thiserror` for most of...

protocols/gossipsub: Support peer exchange

11

Implement the Gossipsub _Peer Exchange_ mechanism, see [specification](https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#prune-backoff-and-peer-exchange). Dependencies: - [x] Signed Envelope and Peer Record: Added via https://github.com/libp2p/rust-libp2p/pull/2107/ Today the mentions of _Peer Exchange_ in the Gossipsub implementation are...

Instead of implementing Protobuf en-/decoding in each protocol and for each message exchange, one can instead implement a custom encoder abstracting the en-/decoding of Protobuf messages. This is done for...

Consider adding the below to your `Cargo.toml` to have all features documented on `docs.rs`: ``` toml [package.metadata.docs.rs] all-features = true ``` https://github.com/libp2p/rust-libp2p/blob/6cc3b4ec52c922bfcf562a29b5805c3150e37c75/Cargo.toml#L68-L69 This might be a deliberate choice. Feel free...

*: Move to `parking_lot` and thus make `owning_ref` obsolete

10

Before `proemtheus-client` would use the `owning_ref` crate to map the target of a `std::sync::RwLockReadGuard`. `owning_ref` has multiple unsoundness issues, see https://rustsec.org/advisories/RUSTSEC-2022-0040.html. Instead of replacing `owning_ref` with a similar crate, we...

Expensive metric validation in debug mode

10

When run in debug mode, I think it is worth exploring running different validations on the registered metrics. Examples: - [ ] We could make sure a counter name does...

src/metrics: Support custom ad-hoc metrics

1

Some metrics need to be created ad-hoc on scrape, e.g. a counter retrieved from another system.

Support deriving `Encode` for [New Type Idiom](https://doc.rust-lang.org/rust-by-example/generics/new_types.html). ```rust #[derive(Encode)] struct SomeNewType(u64) ```