*: Replace implementations of `Display` and `Error` on errors with `thiserror`

[mxinden]

I would argue that a generated implementation of Display and Error via thiserror is faster to write and easier to maintain. Thus I advocate for using thiserror for most of not all libp2p error types.

[demfabris]

I got this

[dignifiedquire]

This means adding another error related dependency, that has no no_std support. :/

Ref https://github.com/dtolnay/thiserror/pull/64

[demfabris]

@mxinden thoughts?

[mxinden]

This means adding another error related dependency, that has no no_std support. :/

We already depend on thiserror in most libp2p-xxx crates, e.g. libp2p-swarm and libp2p-core. In addition, in case we ever decide to be no_std compatible, I don't think it is particularly hard to revert this change, in the sense that it would not be particularly interwoven with other functionality.

I don't have much experience with no_std. With the discussions in https://github.com/libp2p/rust-libp2p/issues/627 in mind, I wonder whether this is a goal we can achieve in the first place. @dignifiedquire do you think no_std is a goal worth striving for?

[dignifiedquire]

if we already depend on it, then nvm in regards to this specific instance

[mxinden]

@demfabris still want to tackle this one? :innocent:

[demfabris]

Yep @mxinden 👍🏻

[thomaseizinger]

I'll close this as stale. I don't think it worth having an issue around to track this.