Max Inden

Results 899 comments of Max Inden

> > Played around with this pull request once more over the weekend. > > Outcome is basically [mxinden@1230178](https://github.com/mxinden/rust-libp2p/commit/1230178cd660783a57b895d377621abaa66346e7) which removes the unbounded channels. > > Is it possible to...

> I am still wondering whether it would make more sense to switch to using the `quinn` top level crate, which would integrate well with the new StreamMuxer trait once...

Thanks for reporting. Definitely worth investigating. > Unfortunately, my project may be a bit complex to get running to show a minimal working example. Do you have any WebSocket /...

Thanks for further bisecting this issue! > Perhaps I'm wrong, but it seems like [flushing in frame::Io](https://github.com/libp2p/rust-yamux/blob/24d5464b25c938b786519f75064e8a81f0b3d80d/src/frame/io.rs#L119) polls to send the remaining frame. If sending cannot be completed (returns pending),...

> In the `next()` method's loop, a frame could be fed to the socket and its write completed in the first half of the loop. Once it had been written,...

> So, how can I add a peer to the mesh without dialing? Only dial? You should be able to subscribe to the same topic.

That sounds reasonable to me. Thanks @dmitry-markin for the detailed report. I am not going to work on this any time soon. I am happy to help you implement it...

Given that this is not a subtle change, but a change at the type system, I think users will (a) notice early and (b) can consult the changelog to get...

> It seems the cause for `DialError::WrongPeerId` to contain `ConnectedPoint`, and not `Dialer` or just `Multiaddr` is that [`PendingOutboundConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L89) is based on [`PendingConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L98) also used for [`PendingInboundConnectionError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/connection/error.rs#L93). So they both...

You would need to give us more context in order to help you. What network are you running on? What is the output run with `RUST_LOG=debug`? ...