Max Howell

Results 599 comments of Max Howell

Fixed thanks

I tested locally and linux passes if we remove the other linux specific `ARGS`. ```sh $ du -hd1 prefixes/linux/llvm.org/v16/ 169M prefixes/linux/llvm.org/v16//bin 44K prefixes/linux/llvm.org/v16//libexec 46M prefixes/linux/llvm.org/v16//include 683M prefixes/linux/llvm.org/v16//lib 180K prefixes/linux/llvm.org/v16//share 899M...

> (I still haven't gotten tea set up on my Linux box yet. `pkg -L build llvm.org` in your pantry clone runs it via docker in case you weren't aware...

> if we remove the other linux specific `ARGS`. this was ofc just a test to see if it helped, those ARGS were added by @jhheider for a reason presumably.

``` -- Linker detection: unknown CMake Error at /tmp/eb4c19d9/llvm/cmake/modules/CheckProblematicConfigurations.cmake:14 (if): if given arguments: "STREQUAL" "MSVC" Unknown arguments specified Call Stack (most recent call first): /tmp/eb4c19d9/llvm/cmake/modules/HandleLLVMOptions.cmake:10 (include) -- Configuring incomplete, errors...

seems like a very well thought through organization! great work. Will this pkg become llvm.org/core?

is this shown at runtime or compile time? Specifically when is this warning shown?

I think here Xcode itself is selecting that simulator, we don’t adjust anything that is not specified. This is kinda an unwritten rule on our behavior. Possibly that should change...

If there's a `Package.swift` it will just work. We do this in CI using eg. [this fixture directory](https://github.com/mxcl/xcodebuild/tree/master/fixtures/swift/~5.0). Probs should be documented, but yeah, it should just work. LMK.