mwigh

Results 5 comments of mwigh

@markmcd see comments in #560 I do not know what cases you want to cover

@Gunand3043 The problem is probably that GenerationConfig does not set the fields as required. Your: "Example 2: (working) - Supply a schema through model configuration" is not always working for...

I only mean that it seems that it is loosing required field when creating the response schema, and that code is also in this SDK. See this commit that fixes...

Yes I noticed that too. But I think this was the cleanest way of solving the issue, without creating new functions or modifying _build_schema(). And it is pretty obvious what...

@MarkDaoust Ref your comment in the PR. I think you need to decide on what should be allowed or not, e.g.: ``` class RecipeTypeDict(typing.TypedDict): recipe_name: str ingredient: str yyy: Optional[str]...