Mats Wichmann

Results 560 comments of Mats Wichmann

I have a one-liner patch that allows options coming from `AddOption` to be set using `SetOption`. At the end of `add_local_option`, do: ``` self.values.settable.append(result.get_opt_string().lstrip('-')) ``` Is that a wanted change?...

Okay, it's not quite that simple: this works for boolean options, but needs extra smarts to set correctly for anything else. Smarts which aren't really available: the `set_option` method runs...

Should this be closed? The options topic is complicated, and I've written too much about it, but the issue subject as written is fixed.

I don't recall the exact story for SetOption. If we ever figure it out, I'm happy to remove the recent bit in the manpage that says it doesn't work for...

Okay, swinging back to this again: there is no longer a manpage conflict, so this is no longer a documentation bug. It seems there was a long-ago decision to make...

Since #3983 requests the ability to designate an added option as settable, I'll close this. Feel free to reopen if that's not appropriate.

Regarding this: > If the change adds too much churn (e.g. rewrapping long paragraphs, adding double spaces at the end of each sentence), it can be rejected[2] > 2. This...

> > so leaving a maintainer the ability to reject-because-of-churn-without-getting-unreasonably-flamed indeed seems a good thing to account for > > I might be misunderstanding you & Cam, but I'm not...

One incremental improvement might be to do what has been attempted for options - try to distinguish "value is the default because nothing was specified for this variable" vs. "variable...