Mats Wichmann

Results 560 comments of Mats Wichmann

The usual SCons-y mess here. The internal signature of the `Variables` *function* is: ```python def Variables(files=None, args=ARGUMENTS): ``` The documented signature is: ```python Variables([files, [args]]) ``` The `Variables` class initializer,...

It turns out... yes - my first glance was also to think "oh, it's a singleton". By the time you're in `__init__`, a new instance has already been created. You...

Swung back and checked - it's definitely producing different instances each time you instantiate Variables. It's dead simple to fix - it's a small stanza in `__new__` instead of in...

Forgot to link this to a PR since what started as a single PR (which did have a link in the commntary) was split into a series - the broken...

Just piling on - DefaultEnvironment has a singleton-type behavior, so calls beyond the first don't look at any override arguments, and it just returns the already constructed environment. In fact,...

The only note would be that using `tarfile` module leaves the work being done in-process, which is not necessarily the best choice if there's lots going on and many threads...

Add comment from Discord channel: there may be cases of people who have used the existing implementation to reach into esoteric tar features (esp. GNU tar) via flags passed through...

The code portion of this change is indeed done - I added the "has patch" label then took it back off, as the remaining piece is indeed documentation only.

Those two languages have cvars already for include paths, those are for ones the developer actually knows about - plus any possible backing copies in repositories. This is for the...

I'll revisit this someday, no need to have it hanging around here for now.