Matthew Wear
Matthew Wear
One complication with this approach, is that exporting from browser requires OTLP/JSON. There are also users that prefer JSON encoding over protobuf. See: https://github.com/open-telemetry/opentelemetry-specification/issues/678.
As another data point. To accommodate various user needs we have multiple versions of the collector exporter for JS: * OTLP/JSON: https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-collector * OTLP/Proto over HTTP: https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-collector-proto * OTLP/gRPC: https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-collector-grpc...
Semantically, I agree that the dotted string notation is equivalent to a map, although I'd like to point out, that at least from the tracing client perspective, dotted strings are...
I'd also like to add that with the dotted-string notation, tracing clients can reduce the runtime string allocations to 0 for attribute keys by introducing constants for semantic conventions (and...
Do we expect to maintain this fork for the long term, or is it temporary until the upstream library can be updated?
Offhand configuration errors are really the only thing I can think of as well.
@jpkrohling I wanted to clarify a couple of things about your suggested approach before diving in. I can introduce handling for permanent errors in the [`StartAll`](https://github.com/open-telemetry/opentelemetry-collector/blob/027b4a379c1611832f060fae90cd378eea9fc308/service/internal/builder/receivers_builder.go#L66-L76) method in receivers_builder: ```go...
I suppose introducing a recoverable error (instead of using permanent) as you hinted at earlier might be a little more straightforward and less disruptive to add. I might go that...
@martinisoft > Where/how do I get appraisal support working like it is done in circle-ci? I seem to be missing a step that isn't documented in the porting guide. I...
Just to clarify, will this work include: ActiveSupport, ActionPack, ActionView, ActionRecord, ActionCable, or should this be broken our more granularly?