Michael Waskom

Results 298 comments of Michael Waskom

It looks like your code is using the same reference rule as numpy is, so you're running into the same problem: ```python x = [20.002347, 20.002347, 51.004152, 19.00218, 20.002346] bins...

My suggestion since you are wrapping `histplot` and defining the bins externally is to do `bins = min(bins, MAX_BINS)` where `MAX_BINS` is a reasonable integer that you know makes sense...

One way I have seen this done is to make a stripplot where the width of the jitter is proportional to a kernel density estimate. That seems principled, but would...

You can pass `color` to the `plot_kws` and `diag_kws` parameter dictionaries.

> `sns.pairplot` when no hue is present, now ignores the `palette=` parameter When you say "now ignores" do you mean that it did not do this in the past?

I am open to the idea on the basis that `jointplot` _does_ have a top-level `color=` kwarg that gets passed to both the joint and marginal subplots. So I would...

I don’t think this is worth supporting, I think it should just give clear error that they’re incompatible.

I don’t think your proposed solution would properly handle qualitative palettes or the fact that `mpl_palette` truncates the range it samples discrete colors from. more generally, `desat` is kinda hacky...

> The current situation leads to behavior that feel somewhat undesirable in my opinion. For instance, the following code leads to two different colorings I think this is unrelated to...

Maybe should be handled separately, but same basic issue with dodged horizontal plots: ``` ( so.Plot(tips, y="day", x="total_bill", fill="sex") .add(so.Bar(), so.Agg(), so.Dodge(gap=.1)) ) ``` ![image](https://user-images.githubusercontent.com/315810/178639336-f70ab04c-8228-45c5-bb19-284fd8881975.png)