Max von Forell

Results 13 comments of Max von Forell

I don't think this is specific to `serde_json`. I can reproduce it e.g. with `serde_yaml` as well. This issue has already been filed in the `serde` repo: https://github.com/serde-rs/serde/issues/2035

I've taken a glance at the code for `ureq::Response`, and getting the remote address could be achieved by adding this line: ```rs let remote_addr = stream.socket().and_then(|s| s.peer_addr().ok()); ``` at the...

Sorry for the delay, I've finally found time to look into this again. I've pushed a new implementation that doesn't use `TcpStream::peer_addr()` and where `Response::remote_addr()` returns a `SocketAddr` instead of...

Whoops, I have to admit I forgot about this. 😅 I'd be happy to rebase and resolve the conflicts, but before diving back into `ureq`'s code, it'd be great if...

Glad to hear that! :) I've merged the upstream changes, please take a final look.

Alright, now that I ran `cargo test` with all the features enabled all the tests should compile and pass 😅

> @mvforell There are some conflicts against main. Hm, GitHub says "This branch has no conflicts with the base branch", and my local checkout says: ``` > git fetch upstream...