Marin Veršić

can we drop the `WSV` prefix? what is it's use? _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4310#discussion_r1497047876_

where to put `genesis.json` and `executor.wasm`?

2

I am not sure moving this is correct... A lot of other stuff expects to find `executor.wasm` (and `genesis.json`) there. I think this is why some of the consistency and...

atm we're choosing topology of the next round based on the signees of the block in the current round as a seed. This is susceptible to manipulation. A better solution...

remove MST aggregation from iroha

3

I think we should remove aggregation of MST signatures out of Iroha. Transaction signing should happen outside Iroha and only after all signatures have been collected should it be submitted...

we should store parameters in a map, not a set in `wsv` because with set we can have duplicate entries with different values but the same `ParameterId`

Remove genesis signing from Iroha

11

Genesis should be signed offline and given to Iroha through config. This way no peer needs to know about genesis private key. The functionality to sign genesis (or any) transaction...

`serde` validation hook in deserialize

2

It is quite often that we need to write custom `serde::Deserialize` implementations just to validate structure's invariants. If possible, we should write some sort of a hook into serde macro...

Find out why this tests fails sometimes: ---- signature::secp256k1::test::secp256k1_sign stdout ---- thread 'signature::secp256k1::test::secp256k1_sign' panicked at crypto/src/signature/secp256k1.rs:259:78: called `Result::unwrap()` on an `Err` value: Signing("signature::Error { source: None }") note: run with...

Currently we seem to allow this, but we don't allow burning the last signatory of an account (we have a test ensuring this `public_keys_cannot_be_burned_to_nothing`). Should we also prevent creation of...

I don't think this makes sense anymore since executor can define their own set of instructions