Marin Veršić

Results 160 issues of Marin Veršić

```suggestion triggers: Vec, ``` _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/5027#discussion_r1792745052_

this field should be last as it was before _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/5027#discussion_r1792744894_

We uniquely identify peers only by public key. However, p2p still requires to know exact address of peers. What we would like to do is that network keeps working even...

Enhancement

I wounder how we should deal with more general case when whole topology changed. Step by step: 1. Network is started with peer set A 2. After some height peer...

Bug
question
iroha2-dev

How about we commit a `rust-toolchain.toml` file so that the developers get the rust version corresponding to what we have in CI right away? ```toml [toolchain] channel = "nightly-2024-09-09" ```...

CI

Make executing smart contract an instruction instead of part of `Executable`. I propose we introduce `Execute` and `Execute` instead of having `ExecuteTrigger` instruction This will take care of some API...

Refactor

I understand the signatures correctness is an invariant of `ValidBlock`, but it looks a bit confusing to me that `SignedBlock` only guarantees its signatures are not empty and have no...

We've always suffered from a risk that nodes can silently diverge but this has become especially evident after #4967. The current algorithm works like this: 1. Leader creates a block,...

Consensus

atm `SignatureVerificationError` and `BlockValidationError` don't produce corresponding pipeline events. The code isn't implemented

Bug

IMO `max_faults` is too much. Let's hardcode to some smaller number for now _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4957#discussion_r1743668353_