Daniel Martí
Daniel Martí
As of 9461bd296caec1abb7da62adfa436b469d4a86f2, the original testscript passes; the issue was resolved by https://review.gerrithub.io/c/cue-lang/cue/+/1194425. That commit did not mark this issue as resolved because a closedness bug remained; however, that's unrelated...
@rogpeppe @mpvl is this proposal fully implemented now, then? Should we close this now?
My guess is that between the second and third comment, the line length decreases enough where it starts a new "comment alignment chunk", which just happens to be one character...
Thanks for filing this issue! It is indeed useful and informative even if we can just close it as "resolved by the new evaluator" :) I will leave it open...
I'm going to close this one out just like the other "evalv3-win" issues we have labelled and closed. Unlike the others, I'm not adding a regression test, because the CUE...
I believe this falls under the TODO category; https://review.gerrithub.io/c/cue-lang/cue/+/531168 added a commented out test case as follows: ``` // TODO: disallow dollar as label? This is according to the spec,...
@rogpeppe I do not think it was a typo. See the TODO that Marcel added which I reference in my comment above.
For some more clarity: particularly in terms of regression testing or Unity, it is a lot easier to understand the original writer's intended effect when knowing what version of CUE...
A passing thought: right now we are coupling the language version with the module.cue schema version. It's convenient to do this for us and for most users, because there is...
Another example: right now we have some CUE users on ancient versions like v0.4.3 due to regressions or breakage in later versions of the evaluator. Once they do eventually update...