Daniel Martí

Results 1730 comments of Daniel Martí

I also found slowness due to RemoveID. Inserting 50k entries with a single `storm:"id"` field took tens of seconds, which definitely seemed wrong. After all, it's a primary key, so...

Agreed, as long as the deprecation is clear that it only applies to Go 1.18 or later. We could perhaps also link to https://pkg.go.dev/golang.org/dl/gotip for testing native fuzzing, and the...

That's fair. What I mean is that we need to mention 1.18+ when it comes to switching to native fuzzing as a replacement.

I find that prepopulating the corpus with inputs from the tests is enough for go-fuzz to get to good results in a matter of minutes.

I don't have an opinion unless someone opens an issue on the tracker with a specific problem or proposed change ;) The decoder could certainly be taught an option to...

Do we need one go.mod file per tool dependency? For example, I see no value in different tools using different versions of `x/tools/go/packages`, and it's just going to make the...

To clarify; my point about using a single `go.tools` file is to reduce the overhead that is adding more files or directories to the root of a module. However, one...

Gotcha, thanks. I hadn't thought about the side effects as much as you two have. Not convinced that this is a clear decision, but I see it's a tradeoff. >...

> handles the case where the main package's module might not be tidy/complete If we live in a world where `proxy.golang.org` is the standard for open source software, wouldn't (or...

For what it's worth, Dominik avoiding semver is not by accident. Hopefully that's not a big blocker for tools like gobin.